Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

date_at support #624

Merged
merged 24 commits into from Sep 29, 2014
Merged

date_at support #624

merged 24 commits into from Sep 29, 2014

Conversation

lisps
Copy link
Contributor

@lisps lisps commented Mar 19, 2014

previous PR was #559

@lisps
add parameter at($DATE_AT) and mind revisions
5c2eed9
@lisps
remove property rev from xhtml.php
4bde219 
changed variable name $create_time to $modified_time
@lisps
Merge remote-tracking branch 'remotes/splitbrain/diff_navigation' int…
ac6dc64 
…o revisions
@lisps
fix function name media_isexternal()
78b874e 
remove empty rev from ml()
rename getProperRevision() to getLastRevisionAt()
make getLastRevisionAt() a method of ChangeLog
@lisps
add test getlastrevisionat
4eb5e17
@lisps
localize msg
4c3263a
@lisps
restore old version of pageinfo()
d811780
@lisps
rename function _getProperMediaRevision to _getLastMediaRevisionAt
52dc5ea 
reduce a bit duplicated code
@lisps
add test for empty rev in ml() and wl()
07a7d22
@lisps
Merge remote-tracking branch 'remotes/splitbrain/diff_navigation' int…
a859b8c 
…o revisions
@lisps
change behavior only on date_at
1c8a8d7
@lisps
Merge branch 'splitbrain/diff_navigation' into revisions
f2643d9
@lisps
Merge remote-tracking branch 'origin/diff_navigation' into revisions
d90a79c 
Conflicts:
	inc/parser/xhtml.php
@lisps
fix last merge
df0e21b
@lisps
rename classname
81e7bff
@lisps
check link existence
4cd9f79
@lisps
fix check link existence, have to call getLastRevisionAt for every link
90bee60
@lisps
add missing parameter
cdb5e96
@lisps
Merge remote-tracking branch 'remotes/origin/master' into revisions_l…
e310313 
…ocal
@lisps
add config date_at_format
7b62b42 
change translation message
@lisps
fix config option
115aab0
@lisps
Copy link
Contributor Author

lisps commented Mar 19, 2014

  • with config date_at_format it is possible to change the date format of at. For example using 2014-03-19-10:28:00
  • if the page has not existed at the given date it now says Page did not exist at %s. It was subsequently created at %s. (dates formatted with date_at_format)
  • @selfthinker the function p_locale_xhtml('showrev'); on the media detail page is used like the one on normal page

@lisps lisps mentioned this pull request Mar 19, 2014
Closed
@lisps
Copy link
Contributor Author

lisps commented Apr 8, 2014

what kind of DocUpdate do you meen?

@Klap-in
Copy link
Collaborator

Klap-in commented Apr 8, 2014

All changes that needs an update of the documentation at dokuwiki.org, due to changed or new features, should be tagged with this needDocUpdate. In this case you are adding a new feature.
When a pull request is merged, everyone can find easily the required outstanding doc updates via this tag.

@lisps
Copy link
Contributor Author

lisps commented Apr 8, 2014

ok thanks
is the something else to do/change to get this merged?

@splitbrain
Copy link
Collaborator

two minor things:

  • I don't see a value in having a config variable for the date format used. We could just always use what you used as default - that's sane and good enough for a URL parameter value. I'd even argue we could just always use a timestamp but since we have no UI, yet a humand readable format is a nice gimmik
  • I'm not too found of having another global variable introduced. If it could be avoided it'd be nice but is no big deal

Could you merge master into your branch for easier merging?

@lisps
Copy link
Contributor Author

lisps commented Sep 27, 2014

is this so ok know?

  • i personaly prefer timestamp format, others will requested a readable format - so I am for a config ;)
  • i don't see a way to do it without a global variable, do you?

@splitbrain
Copy link
Collaborator

I really want to get rid of the config option - it will make adding a interface later much harder. how about detecting timestamp or standard date format automatically and support both, but not have a config option?

@lisps
Copy link
Contributor Author

lisps commented Sep 28, 2014

mh, I like the idea .. what about using the strtotime function? It is felxible in detecting time formats even relative ones, and if it fails we assume timestamp or vice versa.

@splitbrain
Copy link
Collaborator

good idea

@scrutinizer-notifier
Copy link

The inspection completed: 1 new issues

splitbrain added a commit that referenced this pull request Sep 29, 2014
@splitbrain
Merge pull request #624 from lisps/revisions
17553fc 
 date_at support
@splitbrain splitbrain merged commit 17553fc into dokuwiki:master Sep 29, 2014
@splitbrain
Copy link
Collaborator

@lisps thanks for your work and patience on this 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ToDo: needDocUpdate ToDo: QuickMerge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lisps @Klap-in @splitbrain @scrutinizer-notifier